Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json and sql template rendering to Grid View #39527

Open
1 of 2 tasks
nathadfield opened this issue May 9, 2024 · 9 comments
Open
1 of 2 tasks

Add json and sql template rendering to Grid View #39527

nathadfield opened this issue May 9, 2024 · 9 comments
Labels
affected_version:2.9 area:UI Related to UI/UX. For Frontend Developers. good first issue type:new-feature Changelog: New Features

Comments

@nathadfield
Copy link
Collaborator

Apache Airflow version

2.9.1

If "Other Airflow 2 version" selected, which one?

No response

What happened?

In Airflow v2.9.1, the Rendered Template link is now missing from the Details tab when in Grid view.

2.8.4

Screenshot 2024-05-09 at 16 18 01

2.9.1

Screenshot 2024-05-09 at 16 18 53

What you think should happen instead?

It is still possible to get to the rendered template via More Details but having this link here is much more convenient.

How to reproduce

Simply start an instance of Airflow 2.9.1.

Operating System

n/a

Versions of Apache Airflow Providers

n/a

Deployment

Astronomer

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@nathadfield nathadfield added kind:bug This is a clearly a bug area:core needs-triage label for new issues that we didn't triage yet area:UI Related to UI/UX. For Frontend Developers. labels May 9, 2024
@nathadfield nathadfield changed the title Rendered Template link missing from Details tab Rendered Template link missing from Details tab May 9, 2024
@RNHTTR RNHTTR removed the needs-triage label for new issues that we didn't triage yet label May 9, 2024
@tirkarthi
Copy link
Contributor

It has been made as a separate section in 2.9.1 in this PR. I guess the removal was intentional.

#39122

cc: @bbovenzi

@nathadfield
Copy link
Collaborator Author

@tirkarthi Hmm, that's a bit disappointing. I hate clicking more than times that I have to, or was previously used to.

@tirkarthi
Copy link
Contributor

Isn't rendered template available in details tab at the bottom? Is the new section missing some details from old page?

@nathadfield
Copy link
Collaborator Author

nathadfield commented May 10, 2024

@tirkarthi Ah, ok, well, I suppose it depends on what is being rendered. For example, SQL being run via the BigQueryInsertJobOperator looks like this when you go to the specific rendered template page which used to be available from Details.

Screenshot 2024-05-10 at 14 40 28

Whereas it looks like this now.

Screenshot 2024-05-10 at 14 40 46

The important thing is that it's not possible to copy and paste the SQL directly from the UI and the previous page is now several clicks away.

@tirkarthi
Copy link
Contributor

Thanks, the legacy page uses renderers along with pformat which indents the dict. Maybe the issue can updated to have formatting for the values like the legacy page.

@nathadfield
Copy link
Collaborator Author

@tirkarthi It's not just about dict, but also the SQL contained within it. If the new page could render both in a similar way then great!

@bbovenzi
Copy link
Contributor

Yes, we should render the json and sql better in the grid view. We should add a copy button too.

@nathadfield
Copy link
Collaborator Author

@bbovenzi Great thanks! I'll change this to a feature request then.

@nathadfield nathadfield added type:new-feature Changelog: New Features and removed kind:bug This is a clearly a bug labels May 13, 2024
@nathadfield nathadfield changed the title Rendered Template link missing from Details tab Add json and sql template rendering to Grid View May 13, 2024
@kaxil kaxil added this to the Airflow 2.10.0 milestone May 14, 2024
@jscheffl
Copy link
Contributor

I also always wanted to contribute this but never came to this. I'd favor making this consistent like the DAG Run Conf which is rendered as a struct with a copy option.

Same applies for XCom results, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:2.9 area:UI Related to UI/UX. For Frontend Developers. good first issue type:new-feature Changelog: New Features
Projects
None yet
Development

No branches or pull requests

7 participants