Best practice: Mock connections AttributeError: type object 'Connection' has no attribute 'get'

[iamtodor]

What do you see as an issue?

Per paragraph https://airflow.apache.org/docs/apache-airflow/2.8.2/best-practices.html#mocking-variables-and-connections
The given example

conn = Connection(
    conn_type="gcpssh",
    login="cat",
    host="conn-host",
)
conn_uri = conn.get_uri()
with mock.patch.dict("os.environ", AIRFLOW_CONN_MY_CONN=conn_uri):
    assert "cat" == Connection.get("my_conn").login

raises an error:

def test_foo():
        conn = Connection(
            conn_type="gcpssh",
            login="cat",
            host="conn-host",
        )
        conn_uri = conn.get_uri()
        with mock.patch.dict("os.environ", AIRFLOW_CONN_MY_CONN=conn_uri):
>           assert "cat" == Connection.get("my_conn").login
E           AttributeError: type object 'Connection' has no attribute 'get'

path/to/test/file.py:12: AttributeError

Solving the problem

Update the doc

Anything else

No response

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[boring-cyborg]

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

[iamtodor]

I assume this one https://airflow.apache.org/docs/apache-airflow/2.1.2/_api/airflow/hooks/base/index.html#airflow.hooks.base.BaseHook.get_connection should be used

[rawwar]

@iamtodor , I think, you can use get_connection_from_secrets method of Connection : https://airflow.apache.org/docs/apache-airflow/stable/_api/airflow/models/connection/index.html#airflow.models.connection.Connection.get_connection_from_secrets

[iamtodor]

@rawwar yup, this approach could also be used. I think yours is better, is that right?

[rawwar]

@rawwar yup, this approach could also be used. I think yours is better, is that right?

Yeah, I think get_connection_from_secrets is correct. But, You can raise a PR with get_connection_from_secrets and request a review.