Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visual presentation of task log groups #39471

Open
1 task done
dstandish opened this issue May 7, 2024 · 4 comments
Open
1 task done

Improve visual presentation of task log groups #39471

dstandish opened this issue May 7, 2024 · 4 comments
Assignees
Labels
area:UI Related to UI/UX. For Frontend Developers. good first issue kind:meta High-level information important to the community

Comments

@dstandish
Copy link
Contributor

Body

I think that we should also strip out everything prior to the > in the log group heading. It's not a real log message soe the timestamp and source are meaningless.

image

I think it's also nice to consider maybe removing the "end group" message and instead just wrap the whole group in a box with a thin line. This would reduce the overall noise of the feature.

We should also consider adding toggles to expand / collapse all.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@dstandish dstandish added kind:meta High-level information important to the community good first issue labels May 7, 2024
@dstandish dstandish changed the title Enhance task log grouping Improve visual presentation of task log groups May 7, 2024
@bbovenzi
Copy link
Contributor

bbovenzi commented May 7, 2024

  1. Let's make a expand/collapse all toggle
  2. I agree we can have a symbolic representation of "Log group end" instead of literally writing it out.

@bbovenzi bbovenzi added the area:UI Related to UI/UX. For Frontend Developers. label May 7, 2024
@aojunhao123
Copy link

I want to challenge this issue

@dstandish
Copy link
Contributor Author

I want to challenge this issue

assigned to you @aojunhao123

@jscheffl
Copy link
Contributor

Note that when I contributed this I had some challenges because of JavaScript security. From outside the log panel it was somehow (don't know why) not possible to directly set all details, especially events on the DOM of the logs. So I don't know if a "toggle all" is simple. But might be a feature.

One comment for the desire to remove time stamps:
Grouping is made based on logs which itself have time stamps. If you see it visual it might be important knowing when the group was made, if no other log statements immediately follow with a time stamp. The grouping message by itself might be standing along. Therefore I kept the timestamps by intent not to lose information.

Also I by intent left the end of the group as a line, else if you remove this you visually don't see anymore in the log text where the group actually ends.
If there is a group following the other it might be clear, otherwise if a group ends and other log lines continue you can not associate which content was belonging to the group. I'd propose to keep a visual signal what content is grouped as the grouping script does not carry an animation and just hides. If you want to remove the line with the end, please consider any kind or alternative highlight or marker to show where the end of the group is.

Note: As working with Airflow and Github I needed to realize that the log loading of Github is really painful and slow, Airflow log loading is fast in the browser. Also Github does not allow nested groups (groups in groups) which the current solution allows...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. good first issue kind:meta High-level information important to the community
Projects
None yet
Development

No branches or pull requests

4 participants