New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve visual presentation of task log groups #39471
Comments
|
I want to challenge this issue |
assigned to you @aojunhao123 |
Note that when I contributed this I had some challenges because of JavaScript security. From outside the log panel it was somehow (don't know why) not possible to directly set all details, especially events on the DOM of the logs. So I don't know if a "toggle all" is simple. But might be a feature. One comment for the desire to remove time stamps: Also I by intent left the end of the group as a line, else if you remove this you visually don't see anymore in the log text where the group actually ends. Note: As working with Airflow and Github I needed to realize that the log loading of Github is really painful and slow, Airflow log loading is fast in the browser. Also Github does not allow nested groups (groups in groups) which the current solution allows... |
Body
I think that we should also strip out everything prior to the
>
in the log group heading. It's not a real log message soe the timestamp and source are meaningless.I think it's also nice to consider maybe removing the "end group" message and instead just wrap the whole group in a box with a thin line. This would reduce the overall noise of the feature.
We should also consider adding toggles to expand / collapse all.
Committer
The text was updated successfully, but these errors were encountered: