New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid escape sequence in EKS Hook module #39252
Labels
area:providers
good first issue
kind:meta
High-level information important to the community
provider:amazon-aws
AWS/Amazon - related issues
Comments
Taragolis
added
provider:amazon-aws
AWS/Amazon - related issues
area:providers
good first issue
kind:meta
High-level information important to the community
labels
Apr 25, 2024
Taragolis
changed the title
Fix iInvalid escape sequence in EKS Hook module
Fix invalid escape sequence in EKS Hook module
Apr 25, 2024
Is there more work left in this that I can help with? @Taragolis |
There is only one things remaining, that it exact the thing which describe into the issue This warning which might annoying end users because since Python 3.12+ such warnings become So if you would like to fix, feel free to make a PR |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:providers
good first issue
kind:meta
High-level information important to the community
provider:amazon-aws
AWS/Amazon - related issues
Body
Right now import
airflow/providers/amazon/aws/hooks/eks.py
raise DeprecationWarning / SyntaxWarning (depends on python version)We should avoid to use something that deprecated in Python itself years ago in Python 3.6.
airflow/airflow/providers/amazon/aws/hooks/eks.py
Lines 80 to 81 in b7ac00d
airflow/airflow/providers/amazon/aws/hooks/eks.py
Lines 91 to 93 in b7ac00d
\
in the end of the line make sense only in regular strings, not in triple quoted, however right now it work as intended - remove new line in the end of the lineNote
This rule right now ignored in statical code checks (provided by ruff rule
W605
) on module levelairflow/pyproject.toml
Lines 392 to 393 in 79b5443
So it also required to remove this lines from
pyproject.toml
,Warning
Ruff Autofix suggest use raw string here, however it is not a case here and better rewrite built this command.
Previous attempt #38734 is reverted #38864
Committer
The text was updated successfully, but these errors were encountered: