Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to display byte count for Top-languages #3707

Open
abap34 opened this issue Mar 23, 2024 · 7 comments · May be fixed by #3708
Open

Add an option to display byte count for Top-languages #3707

abap34 opened this issue Mar 23, 2024 · 7 comments · May be fixed by #3708
Labels
enhancement New feature or request. feature lang-card Issues related to the language card. ⭐ top feature Top feature request.

Comments

@abap34
Copy link

abap34 commented Mar 23, 2024 •
edited

Is your feature request related to a problem? Please describe.

Currently, the Top Language Card only displays the percentage of each language used. However, adding an option to display byte counts could incentivize more coding activity, thereby increasing the amount of code generated by individuals.

Describe the solution you'd like

I have already implemented this on my self-hosted github-readme-stats.
( So, if there is demand for this feature from the community, I can clean up the implementation and submit a pull request :)

This can be achieved by making minor modifications to the api/top-lang.js and src/cards/top-languages-card.js.

Describe alternatives you've considered

No response

Additional context

It might require CSS adjustments for many layouts. For instance, the default layout appears as follows:
@abap34 abap34 added the enhancement New feature or request. label Mar 23, 2024
@qwerty541
Copy link
Collaborator

Hey, @abap34! Thanks for your interest in our project and submitting feature request. You're right, we use top issues dashboard to prioritize and track community demand, if this feature will be supported by the community feel free to open a pull request for me to review.

@abap34
Copy link
Author

abap34 commented Mar 24, 2024

Thank you for your response @qwerty541!
I'll submit a pull request if it gets featured on the dashboard 😄

@qwerty541
Copy link
Collaborator

Just want to additionally note that we can avoid neccesity of making changes in layout by shorter formatting of bytes numbers: 670,404 bytes => 670k bytes. Also we can convert bytes in KB, MB and GB when it will be enough for one unit: 670,404 bytes => 670KB.

@github-actions github-actions bot added the ⭐ top feature Top feature request. label Mar 25, 2024
@github-actions github-actions bot mentioned this issue Mar 25, 2024
Open
@abap34
Copy link
Author

abap34 commented Mar 25, 2024

That idea sounds very good!
Given the current number of characters in the percentages, I think a format like "670 KB" would be better.

This issue seems to be featured on the dashboard, so I will implement it and send a pull request.

@qwerty541 qwerty541 added the lang-card Issues related to the language card. label Mar 25, 2024
@qwerty541
Copy link
Collaborator

I want to warn you in advance that review and merging of your pull request can be postponed for several months. We have rule in our team that merging features require approval of at least 2 members. Currently I'm alone active, other members busy, so don't hurry with opening pull request.

@abap34 abap34 linked a pull request Mar 25, 2024 that will close this issue
Open
@abap34
Copy link
Author

abap34 commented Mar 25, 2024 •
edited

Oh, I see. Thank you for letting me know.
Sorry, I've already submitted the pull request, so please review it whenever you have the time.
I appreciate your daily maintenance work!

@qwerty541
Copy link
Collaborator

Thanks for your efforts implementing this feature and for your kind words. I just left a review #3708 (review).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request. feature lang-card Issues related to the language card. ⭐ top feature Top feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add a display bytes option to top-languages card abap34/github-readme-stats
2 participants
@abap34 @qwerty541