Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit-tests that will found problems with new code #303

Open
MaxymVlasov opened this issue Dec 16, 2021 · 4 comments · May be fixed by #461
Open

Add unit-tests that will found problems with new code #303

MaxymVlasov opened this issue Dec 16, 2021 · 4 comments · May be fixed by #461
Labels
estimate/1week Need 1 work week to be done help wanted Extra attention is needed hook/infracost_breakdown Bash hook hook/terraform_checkov Bash hook hook/terraform_docs Bash hook hook/terraform_fmt Bash hook hook/terraform_providers_lock Bash hook hook/terraform_tflint Bash hook hook/terraform_tfsec Bash hook hook/terraform_validate Bash hook hook/terragrunt_validate Bash hook hook/terrascan Bash hook
Milestone
Features implemen...

Comments

@MaxymVlasov
Copy link
Collaborator

MaxymVlasov commented Dec 16, 2021 •
edited

What problem are you facing?

New PR's time to time break existing functional, and that can't be found by PR review.
Here one of the examples why we should test corner cases on PR's: #302

Try to use https://github.com/bach-sh/bach Reason: #252 (comment)
Or https://github.com/bats-core/bats-core
@MaxymVlasov MaxymVlasov self-assigned this Apr 16, 2022
@MaxymVlasov
Copy link
Collaborator Author

MaxymVlasov commented Apr 16, 2022 •
edited

Tried bach - no idea how to test $ARGS value after common::parse_cmdline execution. Test just not go inside for-loop

Branch: https://github.com/antonbabenko/pre-commit-terraform/compare/chore/GH-303/add_unit_tests-BACH
Commit: 5e563be

@MaxymVlasov MaxymVlasov removed their assignment Apr 16, 2022
@MaxymVlasov
Copy link
Collaborator Author

Need to check
https://opensource.com/article/19/2/testing-bash-bats

@MaxymVlasov
Copy link
Collaborator Author

Go/Ruby
https://github.com/cloudfoundry-incubator/kubo-deployment/tree/v0.14.0/src/kubo-deployment-tests

https://t.me/catops_chat/61258

@MaxymVlasov MaxymVlasov mentioned this issue Apr 20, 2022
Open
This was referenced Oct 15, 2022
Open
Closed
@MaxymVlasov MaxymVlasov added the help wanted Extra attention is needed label Jan 27, 2023
@MaxymVlasov
Copy link
Collaborator Author

That works awesome
https://github.com/kward/shunit2

@MaxymVlasov MaxymVlasov removed the help wanted Extra attention is needed label Jan 27, 2023
@MaxymVlasov MaxymVlasov linked a pull request Jan 27, 2023 that will close this issue
Draft
4 tasks
@MaxymVlasov MaxymVlasov self-assigned this Jan 27, 2023
@MaxymVlasov MaxymVlasov mentioned this issue Apr 27, 2023
Merged
4 tasks
@MaxymVlasov MaxymVlasov removed their assignment Feb 24, 2024
@MaxymVlasov MaxymVlasov added the help wanted Extra attention is needed label Feb 24, 2024
@MaxymVlasov MaxymVlasov mentioned this issue Apr 12, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
estimate/1week Need 1 work week to be done help wanted Extra attention is needed hook/infracost_breakdown Bash hook hook/terraform_checkov Bash hook hook/terraform_docs Bash hook hook/terraform_fmt Bash hook hook/terraform_providers_lock Bash hook hook/terraform_tflint Bash hook hook/terraform_tfsec Bash hook hook/terraform_validate Bash hook hook/terragrunt_validate Bash hook hook/terrascan Bash hook
Projects
None yet
Milestone
Features implementing and cleanup wit...
Development

Successfully merging a pull request may close this issue.

chore: Add unit tests antonbabenko/pre-commit-terraform
1 participant
@MaxymVlasov