Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report]: defaultComposer maybe have bug #18

Open
nonzzz opened this issue May 5, 2022 · 0 comments
Open

[Bug Report]: defaultComposer maybe have bug #18

nonzzz opened this issue May 5, 2022 · 0 comments

Comments

@nonzzz
Copy link

nonzzz commented May 5, 2022

Background

Description

When i use this project to generator my sponsors meta info. I found when i remove Backers . And set anthor tier monthlyDollars as 1. I got a mistake.

Just like

image

In my consola

image

Expcet

I noticed that if I run the example it defaults to a blank which is normal. But there may be cases where the user deletes these isn't it? I think defaultComposer should judge 0 and null(undefined) respectively.
Currently. In defaultComposer logic is const finalSponsors = config.tiers!.filter(i => i.monthlyDollars == null || i.monthlyDollars === 0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant