-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variables not used at all within role #134
Labels
question
Further information is requested
Comments
Thank you for taking the time and providing the feedback for this issue. I can agree, some of the values do need validated. More than happy to remove unused variables that are no longer valid. Many thanks uk-bolly |
uk-bolly
added a commit
that referenced
this issue
Feb 19, 2024
Signed-off-by: Mark Bolwell <[email protected]>
Merged
uk-bolly
added a commit
that referenced
this issue
Feb 20, 2024
* change logic thanks to @rjacobs1990 see #175 Signed-off-by: Mark Bolwell <[email protected]> * thanks to @ipruteani-sie #134 Signed-off-by: Mark Bolwell <[email protected]> * Thanks to @stwongst #125 Signed-off-by: Mark Bolwell <[email protected]> * thanks to @sgomez86 #146 Signed-off-by: Mark Bolwell <[email protected]> * Added updates from #115 Signed-off-by: Mark Bolwell <[email protected]> * removed rp_filter in post added in error Signed-off-by: Mark Bolwell <[email protected]> * updated yamllint precommit Signed-off-by: Mark Bolwell <[email protected]> * updated fqcn fo json_query Signed-off-by: Mark Bolwell <[email protected]> * updated Signed-off-by: Mark Bolwell <[email protected]> * fix typo for virt type query Signed-off-by: Mark Bolwell <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]>
ipruteanu-sie
pushed a commit
to siemens/RHEL9-CIS
that referenced
this issue
Feb 21, 2024
* change logic thanks to @rjacobs1990 see ansible-lockdown#175 Signed-off-by: Mark Bolwell <[email protected]> * thanks to @ipruteani-sie ansible-lockdown#134 Signed-off-by: Mark Bolwell <[email protected]> * Thanks to @stwongst ansible-lockdown#125 Signed-off-by: Mark Bolwell <[email protected]> * thanks to @sgomez86 ansible-lockdown#146 Signed-off-by: Mark Bolwell <[email protected]> * Added updates from ansible-lockdown#115 Signed-off-by: Mark Bolwell <[email protected]> * removed rp_filter in post added in error Signed-off-by: Mark Bolwell <[email protected]> * updated yamllint precommit Signed-off-by: Mark Bolwell <[email protected]> * updated fqcn fo json_query Signed-off-by: Mark Bolwell <[email protected]> * updated Signed-off-by: Mark Bolwell <[email protected]> * fix typo for virt type query Signed-off-by: Mark Bolwell <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]>
ipruteanu-sie
pushed a commit
to siemens/RHEL9-CIS
that referenced
this issue
Mar 11, 2024
* change logic thanks to @rjacobs1990 see ansible-lockdown#175 Signed-off-by: Mark Bolwell <[email protected]> * thanks to @ipruteani-sie ansible-lockdown#134 Signed-off-by: Mark Bolwell <[email protected]> * Thanks to @stwongst ansible-lockdown#125 Signed-off-by: Mark Bolwell <[email protected]> * thanks to @sgomez86 ansible-lockdown#146 Signed-off-by: Mark Bolwell <[email protected]> * Added updates from ansible-lockdown#115 Signed-off-by: Mark Bolwell <[email protected]> * removed rp_filter in post added in error Signed-off-by: Mark Bolwell <[email protected]> * updated yamllint precommit Signed-off-by: Mark Bolwell <[email protected]> * updated fqcn fo json_query Signed-off-by: Mark Bolwell <[email protected]> * updated Signed-off-by: Mark Bolwell <[email protected]> * fix typo for virt type query Signed-off-by: Mark Bolwell <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Question
These vars in 'defaults/main.yml' file are not used within role:
rhel9cis_allow_autofs: false (NOTE: Setting to 'false' this variable will disable the automounting service(autofs), used for automatically mounting the filesystem and remote-shares.)
- for example, in ubuntu22 role it was used in templates/ansible_vars_goss.yml.j2
- and afterwards in
tasks/section_1/cis_1.1.9.yml || cis_1.1.x.yml
rhel9cis_rh_sub_user & rhel9cis_rh_sub_password(NOTE: Providing the username and password for "Red Hat Subscription Manager" connection.)
- in RHEL8, they were used for configuring the RH Subscription Manager
rhel9cis_rhnsd_required(NOTE: If var "rhel7cis_rhnsd_required" would be set to false, the rhnsd daemon, which periodically connects to Red Hat Network Satellite to check for updates and notifications, will be stopped.)
- in RHEL7, it was used in tasks/section_1/cis_1.2.x.yml
rhel9cis_bootloader_password()
- Such a variable seem to be used in:
- other
*-CIS-Audit
repos, in 'vars/CIS.yml' file- other
*-CIS
repos, in 'templates/ansible_vars_goss.yml.j2' files for loading the hashed password:but in current repository NO other reference exists for it.
Ensure local interactive user home directories exist
):loop_control
, when iterating over passwd lines.{{ item.id }}
as a label for loop_control.Please let me know about your thoughts on this variable definition without actual usage.
The text was updated successfully, but these errors were encountered: