Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

disk_size and memory_size ignored in molecule.yml #35

Open
lmelwyn opened this issue Nov 28, 2021 · 1 comment
Open

disk_size and memory_size ignored in molecule.yml #35

lmelwyn opened this issue Nov 28, 2021 · 1 comment
Assignees
Labels
bug This issue/PR relates to a bug. enhancement This issue/PR relates to a feature request.

Comments

@lmelwyn
Copy link
Contributor

lmelwyn commented Nov 28, 2021

Hi,

At first, thank you for providing this plugin, and secondly, I noticed that "item." is missing a couple of places, so that some definitions in molecule.yml are ignored when creating vms.

grep -ir "default(" | grep -v item
molecule_libvirt/playbooks/create.yml:        {{ disk_size | default(default_disk_size ) }}"
molecule_libvirt/playbooks/templates/vm/vm.xml.j2:  <memory unit='GiB'>{{ memory_size | default(default_memory_size) }}</memory>
molecule_libvirt/playbooks/templates/vm/vm.xml.j2:  <currentMemory unit='GiB'>{{ memory_size | default(default_memory_size) }}</currentMemory>
molecule_libvirt/playbooks/templates/vm/vm.xml.j2:  <vcpu placement='static'>{{ vcpu | default(default_vcpu) }}</vcpu>

Also, would you consider adding (or accepting) a couple of miscellaneous start and stop functions corresponding to virsh start and shutdown.

Regards,
Lars Melwyn

@goldyfruit
Copy link
Collaborator

goldyfruit commented Dec 2, 2021

@lmelwyn Thanks for reporting this, do you think you could write a pull request for this issue? Once done I'll review it.

About your next question, could you please open a new issue with a detailed description of what you are trying to achieve?

Thanks!

@goldyfruit goldyfruit self-assigned this Dec 2, 2021
@goldyfruit goldyfruit added bug This issue/PR relates to a bug. enhancement This issue/PR relates to a feature request. labels Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. enhancement This issue/PR relates to a feature request.
Projects
None yet
Development

No branches or pull requests

2 participants