-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dark mode "flashing" when sorting by duration in light mode #545
Comments
Hi @evgeni and thanks for another good find. I don't know the fix for this one yet but it likely resides within how we select and load the light or dark bootstrap theme within theme.js: https://github.com/ansible-community/ara/blob/master/ara/ui/static/js/theme.js We load the css files: ara/ara/ui/templates/base.html Lines 16 to 21 in 8eda9c8
And then we use theme.js to select the theme here: ara/ara/ui/templates/base.html Lines 88 to 89 in 8eda9c8
|
twbs/bootstrap#37774 suggests that the javascript theme selection should run as early as possible (instead of at the end of the body like we are doing now) and made blocking in order to resolve or mitigate the issue. I can look into this eventually if no one gets to it first. |
What is the issue ?
Screencast.from.2024-04-29.18-47-51.webm
What should be happening ?
No flashing.
Doesn't happen in darkmode
The text was updated successfully, but these errors were encountered: