Added missing gtid_port to proxysql_backend_servers module #118
Conversation
| gtid_port: | ||
| description: | ||
| - The backend server port where ProxySQL Binlog Reader listens on for GTID tracking | ||
| type: int |
There was a problem hiding this comment.
| gtid_port: | |
| description: | |
| - The backend server port where ProxySQL Binlog Reader listens on for GTID tracking | |
| type: int | |
| gtid_port: | |
| description: | |
| - The backend server port where ProxySQL Binlog Reader listens on for GTID tracking | |
| type: int | |
| version_added: 1.5.0 |
It should also be mentioned in the description, that the default value is 0, even if it's not set by the ansible module.
gtid_port INT CHECK ((gtid_port <> port OR gtid_port=0) AND gtid_port >= 0 AND gtid_port <= 65535) NOT NULL DEFAULT 0,
|
@thanos-k Thanks for the quick PR. You can try to expand the existing test: https://github.com/ansible-collections/community.proxysql/tree/main/tests/integration/targets/test_proxysql_backend_servers/tasks, but it's difficult to see through. |
| bugfixes: | ||
| - modules/proxysql_backend_servers - Added missing gtid_port to proxysql_backend_servers module (https://github.com/ansible-collections/community.proxysql/pull/118). |
There was a problem hiding this comment.
| bugfixes: | |
| - modules/proxysql_backend_servers - Added missing gtid_port to proxysql_backend_servers module (https://github.com/ansible-collections/community.proxysql/pull/118). | |
| minor_changes: | |
| - proxysql_backend_servers - Added missing ``gtid_port`` argument to the module (https://github.com/ansible-collections/community.proxysql/pull/118). |
@thanos-k @markuman I think it should be of the minor_changes: category as it adds a new argument.
SUMMARY
Added missing gtid_port to proxysql_backend_servers module
Fixes #117
ISSUE TYPE
COMPONENT NAME
modules/proxysql_backend_servers