synchronize "use_ssh_args" does not work when delegating

[jnm27]

SUMMARY

The use_ssh_args parameter does not work with delegate_to in the general case. It only happens to work if the delegate_to host happens to be ssh and happens to have the same ssh_args that are intended for the real target.

• If the delegate_to host has any other type of connection besides ssh, then use_ssh_args has no effect at all.
• If the delegate_to host does have an ssh connection, but has ssh_args that are specific to that connection and are incompatible with the real target, then it does not work properly.

ISSUE TYPE

• Bug Report

COMPONENT NAME

synchronize.py

ANSIBLE VERSION

2.15.0

COLLECTION VERSION

1.5.4

CONFIGURATION

OS / ENVIRONMENT

RHEL8

STEPS TO REPRODUCE

Use synchronize.py with delegate_to: to something other than inventory_hostname, with use_ssh_args: True.
Try it with a delegate_to host that is using ssh but has different ssh args, and then try it with a delegate_to host that is not using ssh.

EXPECTED RESULTS

synchronize uses the ssh args for the target host instead of the delegated host

ACTUAL RESULTS

synchronize always uses ssh args from the delegated host and tries to apply them to the target host, if the delegated host is ssh to begin with