feat(mox): add inline method call syntax #277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anp would love some 👀 and feedback whenever you have some time 😊 |
cakekindel
changed the title
anp
reviewed
Jul 18, 2021
There was a problem hiding this comment.
This looks great to me! Sorry for the delay in reviewing, getting vaccinated put a big dent in my open source free time 😅 .
Aside from the doc nit this seems fine to land. Can you run cargo ofl versions to bump the patch version for mox and add an entry to its CHANGELOG.md? That way it will release to crates.io on merge.
| /// To allow calling methods with 0 or more than 1 arguments, | ||
| /// an inline method call syntax is available | ||
| /// | ||
| /// e.g. `<foo {bar()} {baz(123)} />` expands to `foo().bar().baz(123).build()` |
There was a problem hiding this comment.
Can the 123 example have 2 args to motivate usage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #276
MoxBlock- intermediate representation of a "syn-rsx block that needs to be transformed", was an artifact of my tooling around that I left in to easily support more transformations in the futureMoxAttr- now an enum representing the three kinds of attributes supported:<foo bar=123 baz {bingus()}>->foo().bar(123).baz(baz).bingus().build()