Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyfill doesn't check if TextDecoder is missing #21

Open
davidliu opened this issue May 22, 2024 · 0 comments · May be fixed by #22
Open

Polyfill doesn't check if TextDecoder is missing #21

davidliu opened this issue May 22, 2024 · 0 comments · May be fixed by #22

Comments

@davidliu
Copy link

Been using this on react-native, but as of 0.74.0, the underlying hermes engine now includes TextEncoder, but doesn't have TextDecoder. Since the polyfill only checks if TextEncoder exists or not (making the assumption that they'd always exist/not exist together), the polyfill fails to fill in TextDecoder.
@davidliu davidliu linked a pull request May 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for TextDecoder separately davidliu/FastestSmallestTextEncoderDecoder
1 participant
@davidliu