Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Stylesheet targeting same domains wipes existing one #720

Open
ejisoo opened this issue Sep 14, 2022 · 1 comment
Open

[Bug] Stylesheet targeting same domains wipes existing one #720

ejisoo opened this issue Sep 14, 2022 · 1 comment

Comments

@ejisoo
Copy link

ejisoo commented Sep 14, 2022

Describe the bug

An active style sheet targeting existing domains will overwrite the existing style sheet.

Browser

Tested on

  • Firefox 104.0.2 (64-bit)
  • Chrome 105.0.5195.125 (Official Build) (arm64)

I've been using the extension and had the same issue for at least 3-4 major versions for both browsers.

To Reproduce

Steps to reproduce the behavior

  • Go to Add a new style...
  • Target yahoo.com and add some style
:root {
  --black: #000;
}
  • Save and create another style targeting yahoo.com and keep it empty.
/*  */

The previous style is now gone!

Expected behavior

Some options:

  1. Warning that saving the style will overwrite the existing one.
  2. Merge
  3. Better: Merge but warn conflicting styles
  4. Best: Make the user able to name the style and if no name is provided, enumerate so in the style list you see something like
yahoo.com
yahoo.com (1)

Additional context

I try to be careful not to lose any work. Sync doesn't help in this case because I can accidentally sync the overwritten style. This has cost me a great number of custom styles...

@milahu
Copy link

milahu commented Dec 22, 2023

just lost a half hour of work
this is ridiculous, dataloss is a serious bug

possible solution: use crdt to sync between multiple stylebot css editors

related

sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants