Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RateLimiterQueue doesn't process requests evenly when execEvenly option enabled #113

Open
animir opened this issue May 8, 2021 · 2 comments
Open

RateLimiterQueue doesn't process requests evenly when execEvenly option enabled #113

animir opened this issue May 8, 2021 · 2 comments
Labels
investigation

Comments

@animir
Copy link
Owner

animir commented May 8, 2021

Most likely, there is a bug with returned result from a limiter. When any limiter is created with execEvenly and request is delayed, it is delayed with setTimeout, but msBeforeNext is not updated after timeout. RateLimiterQueue relies on msBeforeNext to make decision on how a request should be processed/queued.

Further investigation required.
@animir animir added the bug Something isn't working label May 8, 2021
@animir animir mentioned this issue May 8, 2021
Closed
@animir animir added investigation and removed bug Something isn't working labels Sep 8, 2021
@arslnb
Copy link

arslnb commented Feb 7, 2023

Any updates on this?

@animir
Copy link
Owner Author

animir commented Feb 7, 2023

@arslnb I think, nobody looked into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arslnb @animir