Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update Angular index.html DOM text reinterpreted as HTML #55751

Closed
wants to merge 1 commit into from

Conversation

Shivam7-1
Copy link

@Shivam7-1 Shivam7-1 commented May 10, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

By using innerText, it will avoid the risk of HTML injection, as these properties automatically escape any HTML special characters in the provided text. This helps prevent cross-site scripting (XSS) vulnerabilities by treating the input as plain text rather than interpreted HTML.

@pullapprove pullapprove bot requested a review from thePunderWoman May 10, 2024 15:03
@thePunderWoman thePunderWoman added the area: testing Issues related to Angular testing features, such as TestBed label May 10, 2024
@ngbot ngbot bot added this to the Backlog milestone May 10, 2024
@Shivam7-1
Copy link
Author

Hi @thePunderWoman Could You Please Review This PR
Thanks

@JeanMeche
Copy link
Member

Hi, this is a unit test that we are not looking to update. Thank you for you contribution tough. Feel free to drop any usefull PR, thank you for your understanding.

@JeanMeche JeanMeche closed this May 11, 2024
@Shivam7-1
Copy link
Author

Shivam7-1 commented May 11, 2024

Hii @JeanMeche Thanks For Reviewing
I want to Contribute to Angular Project Could Please Let me Know that How Should I find this is for unit test or not ?
As see this Folder Structure and I don't get it is unit test or function

Regards

@Shivam7-1
Copy link
Author

Hi @thePunderWoman Could You Please Review This PR
Ad I think this file is not for Unit Test Could
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: testing Issues related to Angular testing features, such as TestBed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants