Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a ngReset event to FormGroupDirective #54599

Open
michaelurban opened this issue Feb 24, 2024 · 2 comments · May be fixed by #55157
Open

Add a ngReset event to FormGroupDirective #54599

michaelurban opened this issue Feb 24, 2024 · 2 comments · May be fixed by #55157
Labels
area: forms
Milestone
needsTriage

Comments

@michaelurban
Copy link

michaelurban commented Feb 24, 2024 •
edited

Which @angular/* package(s) are relevant/related to the feature request?

forms

Description

Reusable form error components often use FormGroup.submitted to determine whether errors should be displayed. FormGroup.ngSubmit is used to detect when the submitted state has been updated. Unfortunately there's no way to detect reset changes.

See Also:

#10999
#30987
Especially: #30987 (comment)

Proposed solution

Add a ngReset event to FormGroup.

Alternatives considered

N/A
@ngbot ngbot bot added this to the needsTriage milestone Feb 24, 2024
@michaelurban
Copy link
Author

I think I picked the right time to revisit my input wrapper. I'm glad you're on the job @JeanMeche.

@michaelurban
Copy link
Author

@JeanMeche Do you think this is something that will be addressed soon or should I assume that the status quo will remain for the foreseeable future?

physicx237 added a commit to physicx237/angular that referenced this issue Apr 1, 2024
@physicx237
feat(forms): adding ngReset event emitter to the FormGroupDirective
c39ab0a 
<BLANK LINE>
This change allows get the form reset event
<BLANK LINE>
Fixes angular#54599
physicx237 added a commit to physicx237/angular that referenced this issue Apr 1, 2024
@physicx237
feat(forms): adding ngReset event emitter to the FormGroupDirective
0da2f58 
This change allows get the form reset event

Fixes angular#54599
physicx237 added a commit to physicx237/angular that referenced this issue Apr 1, 2024
@physicx237
feat(forms): adding ngReset event emitter to the FormGroupDirective
a048904 
This change allows get the form reset event

Fixes angular#54599
@physicx237 physicx237 linked a pull request Apr 1, 2024 that will close this issue
Open
14 tasks
physicx237 added a commit to physicx237/angular that referenced this issue Apr 1, 2024
@physicx237
feat(forms): adding ngReset event emitter to the FormGroupDirective
bebf957 
This change allows get the form reset event

Fixes angular#54599
physicx237 added a commit to physicx237/angular that referenced this issue Apr 1, 2024
@physicx237
feat(forms): adding ngReset event emitter to the FormGroupDirective
82c101b 
This change allows get the form reset event

Fixes angular#54599
physicx237 added a commit to physicx237/angular that referenced this issue Apr 1, 2024
@physicx237
feat(forms): adding ngReset event emitter to the FormGroupDirective
8a4508a 
This change allows get the form reset event

Fixes angular#54599
physicx237 added a commit to physicx237/angular that referenced this issue Apr 1, 2024
@physicx237
feat(forms): adding ngReset event emitter to the FormGroupDirective
bd892da 
This change allows get the form reset event

Fixes angular#54599
physicx237 added a commit to physicx237/angular that referenced this issue Apr 1, 2024
@physicx237
feat(forms): adding ngReset event emitter to the FormGroupDirective
d4da923 
This change allows get the form reset event

Fixes angular#54599
physicx237 added a commit to physicx237/angular that referenced this issue Apr 2, 2024
@physicx237
feat(forms): adding ngReset event emitter to the FormGroupDirective
c4bccdd 
This change allows get the form reset event

Fixes angular#54599
physicx237 added a commit to physicx237/angular that referenced this issue Apr 3, 2024
@physicx237
feat(forms): adding ngReset event emitter to the FormGroupDirective
96a52da 
This change allows get the form reset event

Fixes angular#54599
physicx237 added a commit to physicx237/angular that referenced this issue Apr 20, 2024
@physicx237
feat(forms): adding ngReset event emitter to the FormGroupDirective
170e88f 
This change allows get the form reset event

Fixes angular#54599
physicx237 added a commit to physicx237/angular that referenced this issue Apr 20, 2024
@physicx237
feat(forms): adding ngReset event emitter to the FormGroupDirective
5a6963d 
This change allows get the form reset event

Fixes angular#54599
@JeanMeche JeanMeche mentioned this issue May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: forms
Projects
None yet
Milestone
needsTriage
2 participants
@michaelurban @JeanMeche