New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angulars Service Worker - "beforePushNotification" #55641
Labels
area: service-worker
Issues related to the @angular/service-worker package
Milestone
Comments
In the end we can always add our own service worker. But that was not my goal. I have found a solution - it's not the best way to go, but it works:
|
pkozlowski-opensource
added
the
area: service-worker
Issues related to the @angular/service-worker package
label
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Which @angular/* package(s) are relevant/related to the feature request?
Angular 17.3.x and @angular/pwa
Description
Angulars
ngsw-worker.js
shows notification at any time a "push" event occurs. However, receiving push notifications when the app is open and in the foreground is not a good user experience. Angular's service worker does not offer a direct way to determine whether a notification should finally be displayed or not. The "onPush" method cannot be overwritten, at most it can be extended - which does not lead to the desired result.I tried things with a custom service worker like this:
but without success (It doesn't matter whether
importScripts
is at the top or at the bottom)Proposed solution
A option to set, or a optional function which will return a boolean, like this:
Alternatives considered
A way to override functions like "onPush" in the Service Worker itself.
The text was updated successfully, but these errors were encountered: