fix(core): Fix null dereference error addEvent
#55353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
added
the
requires: TGP
tbondwilkinson
added
target: major
pullapprove
bot
added
requires: TGP
tbondwilkinson
changed the title
addEventaddEvent
iteriani
approved these changes
Apr 15, 2024
tbondwilkinson
force-pushed
the
jsaction-fix-null-container
branch
from
5d22e1a
to
4fd2bc3
Compare
When `cleanUp` is called `containerManager` is set to null. Currently the `EventContract` API assumes that users know not to call further methods on `EventContract`, but this lead to a bug in a downstream app, b/333750059. So instead, this makes a defensive check to make sure it's not null.
tbondwilkinson
force-pushed
the
jsaction-fix-null-container
branch
from
4fd2bc3
to
c527792
Compare
tbondwilkinson
added
the
action: merge
|
Tested with TGP. Failures look unrelated to CL. |
|
This PR was merged into the repository by commit 0cec9e4. |
iteriani
pushed a commit
to iteriani/angular
that referenced
this pull request
Apr 18, 2024
When `cleanUp` is called `containerManager` is set to null. Currently the `EventContract` API assumes that users know not to call further methods on `EventContract`, but this lead to a bug in a downstream app, b/333750059. So instead, this makes a defensive check to make sure it's not null. PR Close angular#55353
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
cleanUpis calledcontainerManageris set to null. Currently theEventContractAPI assumes that users know not to call further methods onEventContract, but this lead to a bug in a downstream app. So instead, this makes a defensive check to make sure it's not null.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
addEventaftercleanUpwill throw an error.Issue Number: b/333750059
What is the new behavior?
addEventaftercleanUpwill not throw an error.Does this PR introduce a breaking change?