-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default save_pdf location is incorrect #380
Comments
Can confirm, produces a file called "sheet.png" (which MacOS won't open) on my install too. Overriding with the "file" parameter on |
I started looking into this a bit when I was bothered by it, and I haven't tried to fix it yet, but I think I traced the problem... The def full_filename(i=nil)
if i.nil?
"#{dir}/#{file}"
else
"#{dir}/#{prefix}#{count_format % i}#{suffix}.png"
end
end At no point is the |
Oops. Small update to what I just wrote: it's not actually the full_filename method. Instead I think it's this Line 32 in 1132233
|
It's saving as sheet.png instead of sheet.pdf
To Reproduce
Steps to reproduce the behavior:
Run on latest dockerized squib
docker run --rm -v "$PWD":/usr/src/app andymeneely/squib ruby main.rb
See that sheet.png is generated. I can rename sheet.png to sheet.pdf and open it fine.
Expected behavior
I expect the output file for save_pdf to default to sheet.pdf
Environment
M1 mac oxs 13 docker v24
The text was updated successfully, but these errors were encountered: