-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git submodule add followed by git crecord fails with IsADirectoryError #27
Comments
Thanks! I’ll try to find time to investigate this. |
By the way, have you tried the latest Git version? It shouldn’t make any difference, but just to be sure. |
andrewshadura
added a commit
that referenced
this issue
Oct 25, 2020
This is a partial solution to #27. The proper solution is to detect submodules by checking what actually is in the tree we’re going to commit, e.g.: $ git ls-tree HEAD^{tree} 040000 tree 2ff93a1a60f91a971c8d308337906139f0c989e0 .dir1 100644 blob c4c4ffc6aa41a87cc618a31d19f6d5724ddf2b10 .file1 100644 blob db2e58b6f2f8a0f1a297df6efeae1616dc03a058 file2 040000 tree db286da7891a18e945ba35d3c7d906d47c5fce35 dir2 040000 tree a0c41a01caaf1ddf01e3944e29f82e0c62e905ed dir3 100644 blob 1331ed7c1f61a78fad666a591e9addd2f12b759a file3 160000 commit 1fae6eaad2c849fe67a082409502eddb8c08de76 submodule1
I’ve added a change which should enable committing submodules, but it still prints a (harmless) error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: