-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zicsr extension is left unimplemented #33
Labels
Comments
Thanks for the recommendation, I left the Zicsr extension there as a placeholder for a future implementation. I will add a warning message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have been working on making sure the Zicsr extension is fully implemented in RARS and so I tried out Jupiter confirm my expectations from my reading of the specification.
I was very surprised when i tried to use
FRCSR x5
, saw that it compiled tocsrrs x5, 11, x0
and when executed didn't change t0. I expected it to usecsrrs x5, 3, x0
.When I looked into the code I found https://github.com/andrescv/Jupiter/blob/00041f32017a010077397640c673dbc541406962/src/main/java/jupiter/riscv/instructions/itype/CSRRC.java#L39-L42
It would be nice if there was some indication that CSR instructions were not expected to work. A warning when assembled or a note in the documentation would be enough (I guess this issue now serves that purpose).
The text was updated successfully, but these errors were encountered: