New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configurting timeout for external-sources #1624
Comments
Hi @abelsromero, thank you for the suggestion. We'll put this in the backlog for consideration. Are you interested in working on this? We'd be happy to point you in the right direction. Thanks again! |
If you can provide specific of what configuration options you feel comfortable I can give it a try. Like what I mentioned, do you think it'd be better to have a number of retries or a total time? |
That would be great! I think total time would be a good starting point. One thing that would be nice is if the setting cascaded--in other words, you could set a global abort-after as well as abort-after values for individual sources: external-sources:
enable: true
abort-after: 10m
maven:
search-upstream-by-sha1: true
base-url: https://search.maven.org/solrsearch/select
abort-after: 5m # override the global config
another-source:
blah-blah: true
# aborts after 10m by inheriting the global config |
What would you like to be added:
A new option to limit the time spent checking external sources. It could be a total time or a number of retries. I assume the latter is simpler but exposes more of the implementation, I leave that to the project leads 🙇
Why is this needed:
Scan just stays for an indefinite time when there's an issue in the search services and nothing is shown in the console, only in debug.
This is happening right now due to issues with
search.maven.org/
, and we found what was causing issues when enabled debug and found the logs. However, it takes a long time to even show that.Additional context:
The text was updated successfully, but these errors were encountered: