-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the is_orig parameter #7
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
An entry in the logs (iso_cotp.log and s7comm.log) cannot be associated with the sender of the message. Since each s7comm-packet causes an entry, this additional information would be very helpful.
Example:
This PCAP generates the following iso_cotp.log:
The first log entry was caused by 134.249.62.206 and the second one by 134.249.61.163. This is not clear by analyzing the log file.
Suggestion: Adding a new column/attribute in each log type (iso_cotp.log and s7comm.log) for the is_orig parameter which is already passed by the event but not used.
Edit: I can also create the pull request with the adjustments. Of course, only if you agree.
The text was updated successfully, but these errors were encountered: