Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly Definition files are missing #116

Open
halfgrey opened this issue Oct 10, 2022 · 2 comments
Open

Assembly Definition files are missing #116

halfgrey opened this issue Oct 10, 2022 · 2 comments
Labels
type: bug Something isn't working

Comments

@halfgrey
Copy link

Expected Behavior

When Unity developers use assembly definition files they should be able to add a reference to the Amplitude assembly definition files so that they can use the SDK. For example AmplitudeSDKCore.asmdef

Current Behavior

The assembly definition files are missing since they are filtered by the .gitignore file. Only the .meta files are still existing.

Possible Solution

Remove asmdef filter from .gitignore and commit asmdef files again so that developers can reference and use the SDK code.

Steps to Reproduce

  1. Create a new empty Unity Project with an example script.
  2. Create an assembly definition file next to that script and name it whatever you like. For example. com.Company.Example
  3. Import Amplitude via Package Manager and the git url
  4. Try to use amplitude in your script (ERROR: You won't be able to use the amplitude c# code as you would need to reference for example AmplitudeSDKCore.asmdef to com.Company.Example.

Environment

  • Amplitude SDK Version: 2.6.0
  • Device: Unity Editor 2021.3.1f1
@halfgrey halfgrey added the type: bug Something isn't working label Oct 10, 2022
@shamruk
Copy link

shamruk commented Feb 6, 2023

Had to create asmdef myself. Took me about 1 minute, but should be there in the 1st place.
PS if will be fixed, plz add the fix also to v2.6.0-no-edm branch/tag

@justin-fiedler
Copy link
Contributor

Hi @shamruk thanks for the heads up on this. Glad you found a workaround. We have this in our backlog but do not have an ETA for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants