Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to compileSdkVersion = 30+ for React Native 72+ Fabric Support #32

Open
alexhernandez opened this issue Aug 21, 2023 · 2 comments
Assignees

Comments

@alexhernandez
Copy link

alexhernandez commented Aug 21, 2023

When building w/ RN 72+ and Fabric (New Arch) is enabled I'm getting the following error:

> Could not create task ':amplitude_experiment-react-native-client:compileDebugJavaWithJavac'.
   > In order to compile Java 9+ source, please set compileSdkVersion to 30 or above

Fix is likely to bump this version here from 29 to >=30:

compileSdkVersion safeExtGet('ExperimentReactNativeClient_compileSdkVersion', 29)

@alexhernandez alexhernandez changed the title Update to compileSdkVersion = 33 for React Native 72+ Support Update to compileSdkVersion = 30+ for React Native 72+ Support Aug 21, 2023
@alexhernandez alexhernandez changed the title Update to compileSdkVersion = 30+ for React Native 72+ Support Update to compileSdkVersion = 30+ for React Native 72+ Fabric Support Aug 21, 2023
@alexhernandez
Copy link
Author

alexhernandez commented Aug 21, 2023

@bgiori I would make an MR but not sure what version is best for your product

@bgiori bgiori self-assigned this Aug 22, 2023
@bgiori
Copy link
Contributor

bgiori commented Aug 22, 2023

Thanks again @alexhernandez. I've added this and your other issue to our backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants