Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin 1.5 is incompatible with Gradle 8 #31

Open
dereklucas opened this issue Jul 21, 2023 · 1 comment
Open

Kotlin 1.5 is incompatible with Gradle 8 #31

dereklucas opened this issue Jul 21, 2023 · 1 comment

Comments

@dereklucas
Copy link

After updating to Expo SDK 49 I found this plugin won't build for Android.
While building, it threw the error

@TaskAction annotation on method AbstractKotlinCompile.execute() because interface org.gradle.api.tasks.incremental.IncrementalTaskInputs is not a valid parameter to an action method.

After some research, it seems this is a conflict between Kotlin 1.5 and Gradle 8. Bumping this plugin's kotlin version to 1.6.0 fixed it.
I used patch-package to patch @amplitude/[email protected] to apply this diff:

diff --git a/node_modules/@amplitude/experiment-react-native-client/android/build.gradle b/node_modules/@amplitude/experiment-react-native-client/android/build.gradle
index 4a3e823..2171b68 100644
--- a/node_modules/@amplitude/experiment-react-native-client/android/build.gradle
+++ b/node_modules/@amplitude/experiment-react-native-client/android/build.gradle
@@ -1,5 +1,5 @@
 buildscript {
-    ext.kotlinVersion = "1.5.30"
+    ext.kotlinVersion = "1.6.0"
     repositories {
         google()
         mavenCentral()

If you'd like me to open a PR similar to #27 but narrowed to only the kotlin version, let me know.

@bgiori
Copy link
Contributor

bgiori commented Aug 22, 2023

@dereklucas Thanks! PR is always very much appreciated. I have a number of open issues on this SDK, so I'll add this to the backlog and try to get them all done at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants