-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ampli CLI API_URL
and APP_ENV
env var conflicts
#600
Labels
bug
Something isn't working
Comments
If you happen to be using file name:
|
Hi @aweber1, thanks for reporting this and sharing the fix patch. We will look further into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since the
@amplitude/ampli
CLI library is not on GitHub (why?), I'm opening this issue here.The
ampli
CLI for some reason references environment variables in emitted code and unfortunately at least three of the env vars it references are named too generically:process.env.API_URL
,process.env.APP_ENV
,process.env.APP_URL
. I would highly suggest changing those env vars to be scoped to theampli
library, e.g.AMPLI_CLI_API_URL
,AMPLI_CLI_APP_ENV
,AMPLI_CLI_APP_URL
or similar. OR, better yet, don't ship package code that reads env vars - specifically to avoid issues like this. Instead, always make config injectable.Version:
@amplitude/ampli 1.34.0
The text was updated successfully, but these errors were encountered: