Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fail with Node 18 #576

Open
moonjava2005 opened this issue Sep 11, 2023 · 0 comments
Open

Build fail with Node 18 #576

moonjava2005 opened this issue Sep 11, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@moonjava2005
Copy link

I run build on CircleCI with Node 18. I got this error

ERROR in ../../node_modules/@amplitude/analytics-node/lib/esm/transports/http.js 3:0-29
Module not found: Error: Can't resolve 'http' in '/home/circleci/fe/node_modules/@amplitude/analytics-node/lib/esm/transports'
Did you mean './http'?
Requests that should resolve in the current directory need to start with './'.
Requests that start with a name are treated as module requests and resolve within module directories (node_modules).
If changing the source code is not an option there is also a resolve options called 'preferRelative' which tries to resolve these kind of requests in the current directory too.

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
- add a fallback 'resolve.fallback: { "http": require.resolve("stream-http") }'
- install 'stream-http'
If you don't want to include a polyfill, you can use an empty module like this:
resolve.fallback: { "http": false }

ERROR in ../../node_modules/@amplitude/analytics-node/lib/esm/transports/http.js 4:0-31
Module not found: Error: Can't resolve 'https' in '/home/circleci/fe/node_modules/@amplitude/analytics-node/lib/esm/transports'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
- add a fallback 'resolve.fallback: { "https": require.resolve("https-browserify") }'
- install 'https-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
resolve.fallback: { "https": false }

webpack compiled with 2 errors

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce

Environment

  • JS SDK Version: 1.3.3
  • Installation Method: yarn
  • Browser and Version:
@moonjava2005 moonjava2005 added the bug Something isn't working label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant