Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client):LicenseIndicatorContainer component #8653

Merged
merged 9 commits into from
Jun 16, 2024

Conversation

yuval-hazaz
Copy link
Member

@yuval-hazaz yuval-hazaz commented Jun 15, 2024

Close: #8652

PR Details

  • Remove unused code paths and properties.
  • Update tooltip text
  • Update tooltip font size
image image

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

nx-cloud bot commented Jun 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6707dcc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@morhag90 morhag90 merged commit 7f0bb3b into next Jun 16, 2024
11 checks passed
@morhag90 morhag90 deleted the refactor/license-indicator branch June 16, 2024 08:46
@morhag90
Copy link
Member

Passed QA:

image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LicenseIndicatorContainer has several unused properties and code paths
2 participants