Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server):send error per entity #8424

Merged
merged 2 commits into from May 8, 2024
Merged

Conversation

yuval-hazaz
Copy link
Member

Close: #8423

PR Details

Create multiple entities at once, with a seperate catch clause for each entity, and return a separate error message per entity to allow successful creation of the other entities

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

nx-cloud bot commented May 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 263f354. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@mulygottlieb mulygottlieb merged commit d6c428b into next May 8, 2024
11 checks passed
@mulygottlieb mulygottlieb deleted the fix/duplicate-entities branch May 8, 2024 16:18
@overbit overbit mentioned this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Jovu create duplicate entities when one of the entities failed to create
2 participants