-
Related issue: #5440
When implementing the smart git strategy, we used a git-client library (simple-git) to clone the repository very early in the create pull request flow. Therefore, I think we can and should change the implementation to use only git commands for this process. We already have this PR that I created as a part of the pull request flow for Bitbucket. I changed the way we deal with the commit list that we (as Amplication) committed in the repo. There are some side effects in this PR that we need to discuss, and the same goes for the side effects that may happen if we change all the create pull request flow to work with git client lib instead of REST API. The pros are obvious regarding performance. |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments
-
@abrl91 like you mentioned, the upside is clear |
Beta Was this translation helpful? Give feedback.
-
It seems clear that we would prefer, as a strategic decision, to leverage |
Beta Was this translation helpful? Give feedback.
It seems clear that we would prefer, as a strategic decision, to leverage
git
, or any already implemented "git cli proxy", for any operation that is specifically git related (i.e. commits, pulls, push, merge, repo initialisation, etc) leaving the rest of interaction to a provider to its own APIs (for rest of interactions I speak about things like create pull request, create a repository, add comments to PR, etc)