Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle LOADING Redis is loading the dataset in memory errors #67

Open
danog opened this issue Dec 31, 2020 · 3 comments
Open

Comments

@danog
Copy link
Sponsor

danog commented Dec 31, 2020

Hi,

It would be awesome if the lib could internally handle and avoid LOADING Redis is loading the dataset in memory errors, returned if the server has just started up :)

@kelunik
Copy link
Member

kelunik commented Dec 31, 2020

How should it handle them?

@danog
Copy link
Sponsor Author

danog commented Dec 31, 2020

I assume connection could be retried automatically within a certain timeout; I did simply add a systemd service dependency to redis to fix the issue in my case, but still, it still kind of feels like a problem that can be abstracted away.

@kelunik
Copy link
Member

kelunik commented Jan 3, 2021

There are many variables at play here that might need tuning, e.g. retry count, retry delay, etc. I think this should be solved with a decorator of another QueryExecutor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants