Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(devcontainer+docker): Add devcontainer and docker support #66

Merged
merged 23 commits into from
May 22, 2024
Merged

feat(devcontainer+docker): Add devcontainer and docker support #66

merged 23 commits into from
May 22, 2024

Conversation

amitds1997
Copy link
Owner

@amitds1997 amitds1997 commented Jan 4, 2024 •
edited

Closes #68
Closes #69

Using devpod CLI to power the process, we are going to provide docker and devcontainer support.

Following tasks should be completed to get this ready:

  • All operations are async
  • Telescope integration for all operations
  • Checkhealth for devpod binary
  • Add devpod version check before container-based launch
  • For image/container launch, neovim launches at WORKDIR, if set, else let it go to default
  • Add configuration options for: dotfiles_path, gpg-agent-forwarding
  • Support to run Neovim with any devpod workspace (this can help when you are deploying into say k8s pod)
  • Add tests for all new features
  • Automatically detect devcontainer project on directory change.

@amitds1997 amitds1997 mentioned this pull request Jan 4, 2024
Closed
@amitds1997 amitds1997 force-pushed the feat/docker-devcontainer-support branch 3 times, most recently from 36e77fc to 8c4d37f Compare January 16, 2024 08:06
@amitds1997 amitds1997 force-pushed the feat/docker-devcontainer-support branch 3 times, most recently from ef9511f to fb98c05 Compare January 27, 2024 16:37
@amitds1997 amitds1997 force-pushed the feat/docker-devcontainer-support branch 5 times, most recently from 003381a to adffa51 Compare April 28, 2024 04:40
@amitds1997
feat(devpod+docker): Add support for docker and devcontainer
5014a5c
@amitds1997
feat(async): add nio for async
352be8f
@amitds1997
fix(provider): better neovim stop
ecf99f2 
Earlier, we used to stop by sending a remote command to the remote
neovim instance. This caused issues in cases where the remote instance
is blocked by a sync operation. Now, we kill the job handling the
process which in turn kills the remote job for us.
@amitds1997
feat(devpod): Implement cleanup functions
5066f5e
@amitds1997
feat(devpod): auto-stop devpod workspace on Neovim exit
e73e214
@amitds1997
feat(remote-nvim): improve checkhealth and add nio check
ec0a59d
@amitds1997
fix(devpod): Better detection of active devpod workspace
69799e5
@amitds1997 amitds1997 force-pushed the feat/docker-devcontainer-support branch from 041a5f0 to 69799e5 Compare May 8, 2024 18:08
@amitds1997
Copy link
Owner Author

Time to add docs 🎉

@amitds1997 amitds1997 force-pushed the feat/docker-devcontainer-support branch from 264ffa0 to 31e437b Compare May 14, 2024 04:55
@amitds1997 amitds1997 force-pushed the feat/docker-devcontainer-support branch from 9dcee72 to 02740a6 Compare May 14, 2024 05:32
@amitds1997 amitds1997 force-pushed the feat/docker-devcontainer-support branch from 2ac3f4d to 71d261b Compare May 14, 2024 06:07
@amitds1997 amitds1997 force-pushed the feat/docker-devcontainer-support branch from 0025cfa to 74a7255 Compare May 15, 2024 10:08
@amitds1997
fix(devpod): handle hostname truncation
978dcec 
Hostname ending in a `-` breaks devpod and/or ssh.
@amitds1997 amitds1997 force-pushed the feat/docker-devcontainer-support branch from 4fe1aa1 to 978dcec Compare May 15, 2024 15:47
@amitds1997 amitds1997 force-pushed the feat/docker-devcontainer-support branch from 3d9c6a0 to f01778b Compare May 21, 2024 16:52
@amitds1997 amitds1997 merged commit 7e8b322 into main May 22, 2024
@amitds1997 amitds1997 deleted the feat/docker-devcontainer-support branch May 22, 2024 02:23
@github-actions github-actions bot mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docker support Add devcontainer support
1 participant
@amitds1997