Skip to content
This repository has been archived by the owner on Jun 17, 2023. It is now read-only.

Question on memory leak #87

Open
daver234 opened this issue Jan 1, 2023 · 1 comment
Open

Question on memory leak #87

daver234 opened this issue Jan 1, 2023 · 1 comment

Comments

@daver234
Copy link

daver234 commented Jan 1, 2023

Hi,

I using ScalePageView to show 10 different video that are bundled in the app. In profiling the app with the Xcode Leak Instrument, I see leaks related to PagingCollectionViewController.update and .collectionView.

In the Leak tool, when I double click on the cellForItemAt I get the cell.update....and I see that parent captures self. I'm wondering if this causes a leak when the cell gets dequeued or for some other reason? It could be my implementation that is some how causing this. I did run your sample app in the Leak tool and the same leak does not occur.

Would you have any suggestions and how I can further debug or eliminate this leak?

Thanks,
Dave
Paging1
pagingCellClick

@amirdew
Copy link
Owner

amirdew commented Jan 8, 2023

Hi, thanking for reporting the issue, I can tell the line you mentioned cell.update(value: list[indexPath.row], index: indexPath, parent: self) doesn't cause any memory leak since it's not async, but there might be another cause.
Could you send a simple project that reproduces the memory leak issue? I can use that to investigate the problem

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants