Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: sheep-cli panics on input with globbing (Windows) #32

Open
joarfish opened this issue Jan 5, 2020 · 0 comments
Open

Bug: sheep-cli panics on input with globbing (Windows) #32

joarfish opened this issue Jan 5, 2020 · 0 comments

Comments

@joarfish
Copy link

joarfish commented Jan 5, 2020

Issue

When I specify the input files using globbing, sheep-cli crashes with

thread 'main' panicked at ' Failed to open image: IOError(Os { code: 123, kind: Other, message: "The filename, directory name, or volume label syntax is incorrect." })

I looked into it and found out that this is due to Windows not expanding input arguments using globbing.

Possible Fix

Use glob crate to expand inputs with globbing.
@joarfish joarfish mentioned this issue Jan 5, 2020
Open
conectado added a commit to conectado/sheep that referenced this issue Apr 11, 2020
@conectado
Add glob crate to read library path instead of relying on the OS
5b3eb23 
As explained in amethyst#32 relying on the OS to expand globs caused the CLI to fail in
Windows. By using glob it is currently working on Windwos.
@conectado conectado mentioned this issue Apr 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joarfish