Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textures overlap #29

Open
pum-purum-pum-pum opened this issue Oct 16, 2019 · 8 comments
Open

Textures overlap #29

pum-purum-pum-pum opened this issue Oct 16, 2019 · 8 comments

Comments

@pum-purum-pum-pum
Copy link

My texture atlas looks like this in some cases
Screenshot from 2019-10-16 17-53-24
Probably it's due to I'm using too big textures(I will write here when I resize them).

@happenslol
Copy link
Member

That's weird. Can you post the dimensions of the textures you're using, or just post the smallest set of textures the problem can be reproduced with? I'm assuming you're using MAXRECTS?

@pum-purum-pum-pum
Copy link
Author

pum-purum-pum-pum commented Oct 17, 2019

imgs_subset.zip
MAXRECTS inside my packer(UPD: I meant not sheep's packer, but my cli), yes. The same for simple packer with CLI (checked with bigger max_height max_width too)

dimentions:

(333, 27)
(667, 53)
(267, 267)
(133, 133)
(1333, 1333)
(333, 333)
(267, 267)
(267, 267)

@covercash2
Copy link
Contributor

I wrote a function for detecting overlaps a while ago and deleted it for some reason after I squashed my own version of this bug. I'll look into it again tonight

@pum-purum-pum-pum pum-purum-pum-pum changed the title Textures overlap and missing images Textures overlap Oct 18, 2019
@pum-purum-pum-pum
Copy link
Author

Also for MAXRECTS it looks like bins are not working correctly (overlaps are there too both for simple and maxrects)
Screenshot from 2019-11-03 21-13-19

@pum-purum-pum-pum
Copy link
Author

pum-purum-pum-pum commented Nov 3, 2019

Also another bug. I have out of bounds panic error for simple packer on line:

buffer[buffer_idx] = sprite.bytes[sprite_idx];

in sprite.rs
Images subset to reproduce
out_of_bound.zip

@happenslol
Copy link
Member

Thanks for documenting those errors! I'll look into it as soon as I have the time (which will probably be around next weekend).

@pum-purum-pum-pum
Copy link
Author

pum-purum-pum-pum commented Nov 4, 2019

Ok, thank you! I just made temporal hack with piston's texture packer for myself. Mb someone will find it useful kludge_for_mimic_sheep_api

@mashedcode
Copy link

A temporary workaround would be to use jorgebastida/glue and transform the json it outputs to amethyst structs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants