Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require failureThreshold at both percentage and pixel level ? #351

Open
taozhou-glean opened this issue Mar 14, 2024 · 1 comment
Open

Comments

@taozhou-glean
Copy link

we have some large screenshots, the percentage itself (0.001) there can still be large enough to not capture certain changes we want, so would be nice to have a 0.001 with percent and min-pixel like 300 at the same time

@taozhou-glean
Copy link
Author

taozhou-glean commented Mar 14, 2024

here is the proposed interface:

// number for backward compatible
failureThreshold: number | {
  pixel: number,
  percent: number,
}
// or leave `both` out to infer based on above object type
failureThresholdType: "pixel" | "percent" | "both"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant