Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Is the user information in account-management.service.ts secure? #45

Open
wollerman opened this issue Oct 23, 2017 · 0 comments
Open

Is the user information in account-management.service.ts secure? #45

wollerman opened this issue Oct 23, 2017 · 0 comments

Comments

@wollerman
Copy link

After a user signs in, it seems that everything is just saved to local storage:
https://github.com/awslabs/aws-serverless-auth-reference-app/blob/master/app/src/services/account-management.service.ts#L368

Which looks to be the standard javascript localstorage:
https://github.com/awslabs/aws-serverless-auth-reference-app/blob/master/app/src/services/account-management.service.ts#L560

Is this secure? I was surprised to find these keys and tokens being set to default storage. It seems to defeat the purpose and power of cognito by storing the AWS secret access key here.

From what I can tell, best practice is to use local storage. I guess the big issue is storing that particular key and not just the JWT. If this isn't best practice, can you help point me in the direction of how to use cognito and not compromise the user?

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant