Unpin dependencies from [project.optional-dependencies] #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4431 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 352 352
Lines 40035 40041 +6
=======================================
+ Hits 39914 39920 +6
Misses 121 121 ☔ View full report in Codecov by Sentry. |
MichaelFu512
commented
May 30, 2024
| "pre-commit >= 2.20.0", | ||
| "evalml[docs,test]", | ||
| ] | ||
| updater = [ | ||
| "alteryx-open-src-update-checker >= 2.1.0" | ||
| ] | ||
| docs = [ | ||
| "docutils >=0.15.2, < 0.17", | ||
| "docutils >= 0.15.2, < 0.17", | ||
| "pydata-sphinx-theme >= 0.3.1", | ||
| "astroid <= 2.6.6", | ||
| "Sphinx >= 5.0.0", | ||
| "nbconvert >= 6.5.0", | ||
| "nbsphinx >= 0.8.5, < 0.9.0", |
There was a problem hiding this comment.
A combination of nbsphinx, astroid, and docutils cause the readthedocs pipeline to fail. I'll need to open a separate ticket to uncap those.
VascoSch92
reviewed
May 30, 2024
MichaelFu512
requested review from
thehomebrewnerd,
christopherbunn,
jeremyliweishih and
eccabay
| @@ -1530,7 +1530,7 @@ def test_results_getter(AutoMLTestEnv, X_y_binary): | |||
|
|
|||
| assert automl.results["pipeline_results"][0]["mean_cv_score"] == 1.0 | |||
|
|
|||
| with pytest.raises(AttributeError, match="set attribute"): | |||
| with pytest.raises(AttributeError): | |||
There was a problem hiding this comment.
Do you know why the changes lines in this file and in test_pipeline_search_plots.py are showing as uncovered by tests? That seems a bit strange to me.
thehomebrewnerd
approved these changes
May 31, 2024
jeremyliweishih
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #4430
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.