Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing accents from coauthor names causes issues #2409

Open
2 tasks done
kaanaksit opened this issue May 12, 2024 · 1 comment
Open
2 tasks done

Removing accents from coauthor names causes issues #2409

kaanaksit opened this issue May 12, 2024 · 1 comment
Labels

Comments

@kaanaksit
Copy link

Have you checked that your issue isn't already filed?

  • I read through FAQ and searched through the past issues, none of which addressed my issue.
  • Yes, I have checked that this issue isn't already filed.

Bug description

Coauthor names are not highlighted when they have accents in their names

How to reproduce the bug

{%- assign clean_last_name = author_last_name | downcase | remove_accents -%}

The line above has remove_accents, and this causes issues if the surnames have accents or special characters from other languages.

Error messages and logs

The error message you got, with the full traceback if available. Please paste it between these triple backticks.

What operating system are you using?

Linux

Where are you seeing the problem on?

Running locally without Docker

More info

No response

@kaanaksit kaanaksit added the bug label May 12, 2024
@george-gca
Copy link
Collaborator

george-gca commented May 12, 2024

If you look at the line just below:

{% if site.data.coauthors[clean_last_name] %}

This line means that we look for this clean name in the list of coauthors, which in this case are the keys: "adams", "podolsky", "rosen", "bach", "przibram", "schrodinger", "lorentz", "planck". Note that these are just keys to search for these coauthors. When writing their names in the publications we use the names provided in the bib entry, not this key.

What this means is, to ease the search process you should write the coauthors keys with simple chars, removing these special chars, while in the bib entries themselves you can keep all the special chars. Of course you can change this behavior for your site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants