Improve use of jekyll liquid tags #1502
Labels
Comments
george-gca
pushed a commit
that referenced
this issue
Apr 29, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to #1502.
BoAi01
pushed a commit
to BoAi01/boai01.github.io
that referenced
this issue
May 7, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to alshedivat#1502.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just realized that I've been using the tags somewhat wrong. Not wrong, but it could be better. As I saw posted here, simply using
{%- ... -%}instead of{% ... %}reduces the whitespaces created by jekyll.This is not that simple though, since I tried a dumb replace all in our code, and it stopped showing things correctly. I'll leave it here as a reminder that this change might be applied in a lot of different places, but maybe not all of them.
The text was updated successfully, but these errors were encountered: