-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signal Loss Threat #3
Comments
Anyways, there should not only be this kind of protection in case of connection loss for calculating the signal but in general, or did I oversee this being already implemented? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey, saw your Medium article. Wonderful project.
Just wanted to clarify a danger of the algorithm with the line of code
self._bars.rolling(20).mean().close.values
Assuming that internet connection is lost for a couple of minutes and then reconnected, the algorithm is gonna take all last 20 values and may calculate the timeframe wrong.
The collected bar data should always contain a timestamp to be overprotective here and avoid any wrong signals to be produced by checking if there are all bars of the last 20 minutes available and only calculating under these conditions. Makes your algo saver. :)
Keep up the good work and good luck making money with this.
My kindest regards,
The text was updated successfully, but these errors were encountered: