Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monitoring for Executor Services using micrometer ExecutorServiceMetrics #1748

Open
faderskd opened this issue Oct 10, 2023 · 2 comments
Open

Add monitoring for Executor Services using micrometer ExecutorServiceMetrics #1748

faderskd opened this issue Oct 10, 2023 · 2 comments
Assignees
@michal494
Labels
enhancement hacktoberfest

Comments

@faderskd
Copy link
Contributor

faderskd commented Oct 10, 2023 •
edited

Currently we have ExecutorMetrics class for measuring executors in Hermes. Some of the executors are not measured at all. Micrometer has a ExecutorServiceMetrics class which already have similar functionality. We would like to measure every executor service in Hermes using this micrometer class.
@michal494
Copy link
Contributor

I will be working on this issue during Hacktoberfest ;)

michal494 added a commit to michal494/hermes that referenced this issue Oct 18, 2023
@michal494
allegro#1748 WIP
5f7f21b
michal494 added a commit to michal494/hermes that referenced this issue Feb 28, 2024
@michal494
allegro#1748 Add monitoring for Zookeeper cache executor service
a5ce600
michal494 added a commit to michal494/hermes that referenced this issue Feb 28, 2024
@michal494
allegro#1748 Remove unnecessary method
61f66c6
michal494 added a commit to michal494/hermes that referenced this issue Feb 28, 2024
@michal494
allegro#1748 Remove unused methods
25639f9
michal494 added a commit to michal494/hermes that referenced this issue Feb 28, 2024
@michal494
allegro#1748 Remove unused constants
c6cc6d0
michal494 added a commit to michal494/hermes that referenced this issue Feb 28, 2024
@michal494
allegro#1748 Test for monitoring of the executors with Micrometer
1da4fe0
@michal494
Copy link
Contributor

The pull request with the implementation of the refactor is ready for review: #1824

faderskd pushed a commit to michal494/hermes that referenced this issue Mar 21, 2024
@michal494 @faderskd
allegro#1748 WIP
d4f44cb
faderskd pushed a commit to michal494/hermes that referenced this issue Mar 21, 2024
@michal494 @faderskd
allegro#1748 Add monitoring for Zookeeper cache executor service
42734c0
faderskd pushed a commit to michal494/hermes that referenced this issue Mar 21, 2024
@michal494 @faderskd
allegro#1748 Remove unnecessary method
3438ad3
faderskd pushed a commit to michal494/hermes that referenced this issue Mar 21, 2024
@michal494 @faderskd
allegro#1748 Remove unused methods
ea421f5
faderskd pushed a commit to michal494/hermes that referenced this issue Mar 21, 2024
@michal494 @faderskd
allegro#1748 Remove unused constants
19b589b
faderskd pushed a commit to michal494/hermes that referenced this issue Mar 21, 2024
@michal494 @faderskd
allegro#1748 Test for monitoring of the executors with Micrometer
e5c1079
faderskd pushed a commit to michal494/hermes that referenced this issue Apr 15, 2024
@michal494 @faderskd
allegro#1748 WIP
452c9fb
faderskd pushed a commit to michal494/hermes that referenced this issue Apr 15, 2024
@michal494 @faderskd
allegro#1748 Add monitoring for Zookeeper cache executor service
463d812
faderskd pushed a commit to michal494/hermes that referenced this issue Apr 15, 2024
@michal494 @faderskd
allegro#1748 Remove unnecessary method
c9e9cde
faderskd pushed a commit to michal494/hermes that referenced this issue Apr 15, 2024
@michal494 @faderskd
allegro#1748 Remove unused methods
d87ab95
faderskd pushed a commit to michal494/hermes that referenced this issue Apr 15, 2024
@michal494 @faderskd
allegro#1748 Remove unused constants
10621b2
faderskd pushed a commit to michal494/hermes that referenced this issue Apr 15, 2024
@michal494 @faderskd
allegro#1748 Test for monitoring of the executors with Micrometer
fea4ab2
faderskd pushed a commit that referenced this issue Apr 17, 2024
@michal494
#1748 Use metrics provided by Micrometer for monitoring executors (#1824
9da6649 
)

* #1748 WIP

* #1748 Add monitoring for Zookeeper cache executor service

* #1748 Remove unnecessary method

* #1748 Remove unused methods

* #1748 Remove unused constants

* #1748 Test for monitoring of the executors with Micrometer

---------

Co-authored-by: Michal Ciszewski <[email protected]>
faderskd pushed a commit that referenced this issue Apr 19, 2024
@michal494 @faderskd
#1748 Use metrics provided by Micrometer for monitoring executors (#1824
1b2c543 
)

* #1748 WIP

* #1748 Add monitoring for Zookeeper cache executor service

* #1748 Remove unnecessary method

* #1748 Remove unused methods

* #1748 Remove unused constants

* #1748 Test for monitoring of the executors with Micrometer

---------

Co-authored-by: Michal Ciszewski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michal494 michal494

Labels
enhancement hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@faderskd @michal494