Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch subscription should be stoppable despite of pending message retries #1645

Open
faderskd opened this issue Dec 20, 2022 · 0 comments
Open

Comments

@faderskd
Copy link
Contributor

If you have a batch subscription sending messages to the receiver returning 5xx status codes, the messages are retried until TTL is passed. Sending with retries blocks BatchConsumer main loop, thus blocking processing consumer signals. If the subscription was stopped at the moment of retries, it will wait until retries are exhausted. This is not a desired behaviour. The subscription should be stopped immediately even if the are pending retries.

@faderskd faderskd added the bug label Dec 20, 2022
@faderskd faderskd changed the title Batch subscription should be stoppable despite the pending message retries Batch subscription should be stoppable despite of pending message retries Dec 20, 2022
pkasperowicz added a commit to pkasperowicz/hermes that referenced this issue Oct 18, 2023
pkasperowicz added a commit to pkasperowicz/hermes that referenced this issue Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants