Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add time prefix for default logger #900

Open
FeelyChau opened this issue Oct 9, 2021 · 0 comments
Open

cli: add time prefix for default logger #900

FeelyChau opened this issue Oct 9, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@FeelyChau
Copy link
Collaborator

We distinguish different types of terminals by judging process.stdout. On the default terminal, we use console to output logs, while on the TTY terminal, we use the ora. We have added a time prefix to Ttylogger, but this feature has not been implemented on the DefaultLogger.
Here is the DefaultLogger:
https://github.com/alibaba/pipcook/blob/main/packages/cli/src/utils/index.ts#L212
@FeelyChau FeelyChau added the good first issue Good for newcomers label Oct 9, 2021
@FeelyChau FeelyChau changed the title cli: add prefix for default logger cli: add time prefix for default logger Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FeelyChau