fix(Tab): should not be obscured if has extra #4839
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
eternalsky
requested changes
Jun 5, 2024
components/tab/tabs/nav.jsx
Outdated
| @@ -580,7 +580,19 @@ class Nav extends React.Component { | |||
| [`${prefix}tabs-nav-wrap`]: true, | |||
| [`${prefix}tabs-nav-has-add`]: showAdd, | |||
| }); | |||
|
|
|||
| // let extraStyle | |||
components/tab/tabs/nav.jsx
Outdated
| // marginRight: window.getComputedStyle(this.navbar?.childNodes[0]).width | ||
| // } | ||
| // } | ||
| if(this.navbar && this.navbar.childNodes.length===2) { |
There was a problem hiding this comment.
另外代码可以格式化一下，目前有些该空格的地方没有空格
components/tab/tabs/nav.jsx
Outdated
| // } | ||
| // } | ||
| if(this.navbar && this.navbar.childNodes.length===2) { | ||
| this.navbar.childNodes[1].style.setProperty('--extra-width', window.getComputedStyle(this.navbar.childNodes[0]).width); |
There was a problem hiding this comment.
render 在 react 中的调用频次是很频繁的，而且render 中不一定重新渲染还没有完成。一般不会在 render 函数中引入 side effect，而是在类似 componentDidMount 等 lifeCycle 中完成。
components/tab/main.scss
Outdated
| @@ -5,6 +5,10 @@ | |||
| @import "./scss/mixin"; | |||
| @import "./scss/placeholder"; | |||
|
|
|||
| :root { | |||
| --extra-width: 0; | |||
There was a problem hiding this comment.
css 变量还是有一些兼容性问题的，我们目前代码内部没有完全依赖 css 变量的地方。这里其实不使用 css 变量也可以实现。可以参考其他组件，直接操作 dom style 来实现
GCHHCG
force-pushed
the
fix-issue-4808
branch
4 times, most recently
from
b148396
to
2155f04
Compare
eternalsky
reviewed
Jun 6, 2024
| @@ -66,6 +66,9 @@ class Nav extends React.Component { | |||
| this.initialSettings(); | |||
| } | |||
|
|
|||
| if (this.navbar && this.navbar.childNodes.length === 2) { | |||
There was a problem hiding this comment.
感觉只在 didMount 里处理一次是不够的，有可能组件 update 之后情况会发生变化。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4808