Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in dependencies #305

Open
squarefrog opened this issue Feb 2, 2024 · 9 comments
Open

Breaking changes in dependencies #305

squarefrog opened this issue Feb 2, 2024 · 9 comments

Comments

@squarefrog
Copy link

Describe the bug 馃悰
Originally reported in algoliasearch-client-swift but it feels more relevant here. Feel free to close that issue if you like.

One of instantsearch-ios dependencies has introduced a breaking change that prevents instantsearch-ios from building on iOS 15. It bumps the minimum target to iOS 14, but instantsearch-ios has a minimum target of iOS 9. This prevents compilation, even if you are targeting a higher version than iOS 9.

To Reproduce 馃攳
Steps to reproduce the behavior:

  1. Clone this project
  2. Open the Example Xcode project
  3. Wait for package resolution
  4. Attempt to build

Expected behavior 馃挱
Example project should build.

Screenshots 馃枼
Screenshot 2024-02-02 at 15 42 58

Environment:

  • OS: iOS
  • Version 15+
  • Xcode 15

Additional context
You can work around this issue by manually adding https://github.com/algolia/algoliasearch-client-swift to your project, and setting the resolution rule to be exact: 8.19.0

Screenshot 2024-02-02 at 15 44 54
@VladislavFitz
Copy link
Contributor

Hi @squarefrog ,
That's indeed an unexpected breaking change. Thanks for flagging this!
We're preparing an update for InstantSearch iOS to fix it. Expect a release soon.
Meanwhile, your workaround with the explicit client version setting is a good interim solution.

@squarefrog
Copy link
Author

Sounds good!

@r3econ
Copy link

r3econ commented Feb 19, 2024

Hi @VladislavFitz when would the fix go live? Our CI workflows fail with the above-mentioned error

@RebinX1
Copy link

RebinX1 commented Mar 12, 2024

hi is there a fix for this yet?

@Ma7m0udalaa
Copy link

Any update for this?

@salami
Copy link

salami commented Mar 25, 2024

Also waiting on a fix for this

@r3econ
Copy link

r3econ commented Apr 10, 2024

Any update? We'd love to have it fixed :)

@akshaaatt
Copy link

Any update on this?

@r3econ
Copy link

r3econ commented May 10, 2024

@nickvlku any chance having this fixed? 馃ゲ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants