Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Move to golang-http-template #180

Conversation

zoidyzoidzoid
Copy link

Description

I've been trying to do some work on #96 and #123, but maybe I should break it up into multiple PRs.

I definitely need to test it more.

Maybe all the changes will make the most sense to do at once.

Motivation and Context

Closes #96

Might also close #123

How Has This Been Tested?

I've mainly tested this using go test but I should test it properly by actually deploying it with openfaas and things.

I thought it'd be useful to make an MR sooner rather than later, to get as much feedback and direction as possible, since I'm an openfaas noob.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

This change should not break backwards compatibility or the success cases, but might subtly affect some of the error cases, if we are giving more descriptive error messages and status codes.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Closes alexellis#96

Might also close alexellis#123

Signed-off-by: zoidbergwill <[email protected]>
@derek
Copy link

derek bot commented Oct 18, 2021

Thank you for your contribution. It seems that one or more of your commits have an anonymous email address. Please consider signing your commits with a valid email address. Please see our contributing guide.

@derek derek bot added the no-dco label Oct 18, 2021
@alexellis
Copy link
Owner

@zoidbergwill this will need some end to end testing, please see the dev guide in the repository.

faasd is probably the easiest to set up on a public cloud VM, or use inlets to connect your local OpenFaaS environment to GitHub for webhooks.

https://inlets.dev/blog/2020/10/15/openfaas-public-endpoints.html

@alexellis
Copy link
Owner

@zoidbergwill if you have any questions please feel free to drop by on Slack https://slack.openfaas.io in the #contributors channel

@alexellis alexellis closed this Apr 14, 2022
@alexellis
Copy link
Owner

Closing as abandoned.

@zoidyzoidzoid
Copy link
Author

Sorry, I'll try pick this up again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare Derek for use as an SDK/package Move to OpenFaaS golang-http-template - part 2
2 participants